Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove 32bit platform check #5371

Merged
merged 6 commits into from
Sep 4, 2024
Merged

feat: remove 32bit platform check #5371

merged 6 commits into from
Sep 4, 2024

Conversation

kruskall
Copy link
Member

What does this PR do?

remove 32bit platform check on startup
bump elastic-agent-system-metrics lib to completely drop the dependency

Why is it important?

elastic agent dropped support for 32bit systems a long time ago so the check will always pass

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@kruskall
feat: remove 32bit platform check
4b6e557 
elastic agent dropped support for 32bit systems a long time ago
remove the platform check on startup
@kruskall
build: bump elastic-agent-system-metrics to drop gopsutil/v3 dep
5c0f7cb
@kruskall kruskall added the enhancement New feature or request label Aug 28, 2024
@kruskall kruskall requested a review from a team as a code owner August 28, 2024 03:45
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 28, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Aug 28, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ycombinator ycombinator requested review from michel-laterman and pchila and removed request for blakerouse and andrzej-stencel September 3, 2024 23:34
@andrzej-stencel
Copy link
Contributor

Can you point to documentation describing when support for 32-bit platforms was dropped or what was the last version that supported 32-bit platforms?

@kruskall
Copy link
Member Author

kruskall commented Sep 4, 2024

I'll link to the public support matrix to avoid linking to private issues:

From https://www.elastic.co/support/matrix#show_compatibility

Elastic Agent is not supported on 32-bit operating systems.

and

As of 8.0+ Beats do not support 32-bit operating systems.

@kruskall kruskall merged commit 590c506 into elastic:main Sep 4, 2024
13 checks passed
@kruskall kruskall deleted the feat/remove-platformcheck branch September 4, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

@michel-laterman michel-laterman michel-laterman approved these changes

@pchila pchila Awaiting requested review from pchila

Assignees

@kruskall kruskall

Labels
backport-skip enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kruskall @elasticmachine @andrzej-stencel @blakerouse @michel-laterman @pierrehilbert